Conversation
Reason for change: Upgrade RBUS to 2.11.0 which has Coverity Fixes for rtMessage/rbus Test Procedure: Tested and verified Priority: P1 Risks: Medium
Reason for change: The clang compiler is required for the secclient-rs module. This commit integrates the meta-clang recipe, which provides compiler version 1.72.0. Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com>
Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com>
…Firmware Updates (#512)
RDK-59919 : [RDKE] Port Ops Support Upload Scripts to Source code
… topic/RDKEMW-10995-dev
There was a problem hiding this comment.
Pull request overview
This PR updates multiple BitBake recipe files as part of a rebase operation, updating git commit references (SRCREV) and package versions across several RDK middleware components. The changes include routine version bumps for five recipes and a major refactoring of the crashupload recipe to support new build configurations.
Changes:
- Updated SRCREV and versions for commonutilities (1.5.0→1.5.1), telemetry (1.7.4→1.8.0), rfc (1.2.1 with PR bump), rbus (2.9.0→2.11.0), and dcmd (2.0.0→2.0.3)
- Major refactoring of crashupload recipe (1.0.7→2.0.0) with new source structure, client-specific builds, and additional dependencies
- Added meta-clang layer support to bblayers.conf.sample
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| recipes-common/utils/commonutilities_git.bb | Updated SRCREV and bumped version from 1.5.0 to 1.5.1 with PR increment |
| recipes-common/telemetry/telemetry_git.bb | Updated SRCREV and bumped version from 1.7.4 to 1.8.0 |
| recipes-common/rfc/rfc_git.bb | Updated SRCREV and incremented PR from r0 to r1 |
| recipes-common/rbus/rbus.bb | Updated SRCREV and bumped version from 2.9.0 to 2.11.0 |
| recipes-common/dcmd/dcmd.bb | Updated SRCREV and bumped version from 2.0.0 to 2.0.3 |
| recipes-common/crashupload/crashupload_git.bb | Major refactoring: version 2.0.0, new source structure, client-specific support, additional dependencies |
| conf/template/bblayers.conf.sample | Added conditional inclusion of meta-clang layer |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PV = "1.5.0" | ||
| PR = "r0" | ||
| PV = "1.5.1" | ||
| PR = "r1" |
There was a problem hiding this comment.
When PV (package version) is updated, PR (package revision) should typically be reset to "r0". Here PV changed from 1.5.0 to 1.5.1, but PR was incremented to "r1" instead of being reset to "r0". This is inconsistent with the pattern used in other files in this PR (telemetry, rbus, dcmd, crashupload) where PR is reset to "r0" when PV changes.
| PR = "r1" | |
| PR = "r0" |
RDKEMW-13838: Dobby 3.16.1 Release Integration
Co-authored-by: Anand Kandasamy <37086488+anand-ky@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CFLAGS:append = " \ | ||
| -I=${libdir}/glib-2.0/include \ | ||
| -I=${includedir}/glib-2.0 \ | ||
| -DRFC_API_ENABLED \ | ||
| -DT2_EVENT_ENABLED \ | ||
| -DRDK_LOGGER \ | ||
| -DUSE_EXTENDED_LOGGER_INIT \ | ||
| " | ||
|
|
||
| export GLIBS = "-lglib-2.0 -lz" | ||
| export USE_DBUS = "y" | ||
|
|
||
| LDFLAGS += "-Wl,-O1" | ||
| LDFLAGS:append = " -Wl,-O1" | ||
|
|
||
| inherit autotools systemd coverity pkgconfig | ||
|
|
||
| inherit coverity | ||
| inherit systemd | ||
| DEPENDS:append:client = " \ | ||
| openssl \ | ||
| libarchive \ | ||
| rdk-logger \ | ||
| commonutilities \ | ||
| rfc \ | ||
| telemetry \ | ||
| " |
There was a problem hiding this comment.
CFLAGS:append unconditionally enables RFC/T2/RDK logger related defines, but the build-time dependencies for those features are only added under DEPENDS:append:client. If this recipe is built under other overrides (e.g. :broadband), the build may fail or rely on undeclared/transitive deps. Either make the feature flags conditional (match the override) or move the required deps to the base DEPENDS/relevant override.
| do_install() { | ||
| install -d ${D}${base_libdir}/rdk | ||
| install -d ${D}${sysconfdir} ${D}${sysconfdir}/rfcdefaults | ||
| install -m 0755 ${S}/uploadDumps.sh ${D}${base_libdir}/rdk | ||
| install -m 0755 ${WORKDIR}/git/uploadDumps.sh ${D}${base_libdir}/rdk | ||
| install -m 0755 ${WORKDIR}/git/runDumpUpload.sh ${D}${base_libdir}/rdk | ||
| } | ||
|
|
||
| do_install:append:client() { | ||
| install -d ${D}${bindir} | ||
| install -m 0755 ${B}/src/crashupload ${D}${bindir}/crashupload | ||
| } | ||
|
|
||
| do_install:append:broadband() { | ||
| use_sysv="${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'false', 'true', d)}" | ||
| $use_sysv || install -d ${D}${systemd_unitdir}/system | ||
| $use_sysv || install -m 0644 ${S}/coredump-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${S}/coredump-upload.path ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${S}/minidump-on-bootup-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${S}/minidump-on-bootup-upload.timer ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/coredump-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/coredump-upload.path ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/minidump-on-bootup-upload.service ${D}${systemd_unitdir}/system/ | ||
| $use_sysv || install -m 0644 ${WORKDIR}/git/minidump-on-bootup-upload.timer ${D}${systemd_unitdir}/system/ | ||
| install -d ${D}${sysconfdir} | ||
| install -m 0755 ${S}/uploadDumpsUtils.sh ${D}${base_libdir}/rdk | ||
| install -m 0755 ${WORKDIR}/git/uploadDumpsUtils.sh ${D}${base_libdir}/rdk |
There was a problem hiding this comment.
The install steps reference source files via ${WORKDIR}/git/... even though S is set to a subdirectory. This hard-codes the unpack layout and can break developer workflows that enable externalsrc (see conf/distro/include/rdk-external-src.inc) or any future changes to S. Prefer deriving the repo-root path from ${S} (or keep S at repo root and point autotools at the subdir) so installs don’t depend on ${WORKDIR}/git.
No description provided.